| commit | 7b9e678637c22453bd768aec6c0ec5785615a8cc | [log] [tgz] |
|---|---|---|
| author | Saša Živkov <sasa.zivkov@sap.com> | Fri Jan 19 10:08:15 2024 +0100 |
| committer | Saša Živkov <sasa.zivkov@sap.com> | Fri Jan 19 10:37:13 2024 +0100 |
| tree | ade0445927885accb3eb77d54ff8bc829ea02d15 | |
| parent | 29205e5490ef17c6b8bce3b9a9e0820461b3e964 [diff] |
Fix heartbeat task leak after lock reclaim Reclaiming an existing lock (re)started the heartbeat task but it missed to set the heartbeatTask reference. After a reclaimed lock was closed the heartbeat task wasn't stopped because the heartbeatTask reference was null. The heartbeat thread continued to run on the scheduled rate indefinitely. Make sure to set the heartbeatTask reference after a lock is reclaimed. Extend the tests to verify the heartbeat task is running/stopped. Change-Id: Iecb7b77f54ad416a3a4de27bf26942270cfc3c1e
This plugin provides an implementation of the Gerrit global refdb backed by Cloud Spanner.
Requirements for using this plugin are:
A global refdb implementation is a requirement for a Gerrit multi-master scenario in a multi-site setup to ensure refs are updated consistently across multiple Gerrit primary sites.
Refer to the Gerrit multi-site plugin for more details on the high level architecture.
The in-memory Cloud Spanner emulator can be used during development. There are several limitations of the emulator that differ from the production service.
An easy way to run the emulator is to use gcloud CLI and Docker. Following the install instructions here will provide a local instance that the plugin can access. The gcloud CLI commands will be sent to the emulator instead of the production service. A test spanner instance and database will need to be created.
gcloud spanner instances create test-instance --config=emulator-config --description="Test Instance" --nodes=1 gcloud spanner databases create global-refdb --instance=test-instance
There are several limitations of the emulator which differ from the production service.
In order to easily set up and begin testing the @PLUGIN@ plugin, the multi-site plugin's local environment setup can be used.
This simulates a multi-site setup using two local gerrit instances. Build the release.war to include @PLUGIN@ and follow the linked example setup.
Configuration details can be found in the @PLUGIN@ config documentation.
When not used with the emulator, the plugin requires the path to credentials in the config to authenticate with google. To create the key see the official documentation.