Set default createNotes to false Disabling automatic note creation by default addresses two primary concerns: 1. Admin Expectations: Most admins seeking a simple self-service interface for service accounts find automatic note generation unexpected and unnecessary for their workflow. 2. Performance: Reducing metadata overhead prevents impact on push times and Git operations (fetch/GC) on high-traffic, busy servers where excessive Git Notes can inflate the object database. Change-Id: Ic1d449d926858c6add9972c79b5856bab46f9922
diff --git a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/GetConfig.java b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/GetConfig.java index c4aa9e1..2fb7699 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/GetConfig.java +++ b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/GetConfig.java
@@ -69,7 +69,7 @@ info.allowHttpPassword = toBoolean(cfg.getBoolean("allowHttpPassword", false)); info.allowCustomHttpPassword = toBoolean(cfg.getBoolean("allowCustomHttpPassword", false)); info.allowOwner = toBoolean(cfg.getBoolean("allowOwner", false)); - info.createNotes = toBoolean(cfg.getBoolean("createNotes", true)); + info.createNotes = toBoolean(cfg.getBoolean("createNotes", false)); info.createNotesAsync = toBoolean(cfg.getBoolean("createNotesAsync", false)); String[] blocked = cfg.getStringList("block");
diff --git a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutConfig.java b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutConfig.java index af5343d..b65c368 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutConfig.java +++ b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutConfig.java
@@ -89,7 +89,7 @@ setBoolean(cfg, "allowOwner", input.allowOwner); } if (input.createNotes != null) { - setBoolean(cfg, "createNotes", input.createNotes, true); + setBoolean(cfg, "createNotes", input.createNotes, false); } if (input.createNotesAsync != null) { setBoolean(cfg, "createNotesAsync", input.createNotesAsync);
diff --git a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/RefUpdateListener.java b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/RefUpdateListener.java index 421b326..addbaa9 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/RefUpdateListener.java +++ b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/RefUpdateListener.java
@@ -59,7 +59,7 @@ @Override public void onGitReferenceUpdated(final Event event) { PluginConfig cfg = cfgFactory.getFromGerritConfig(pluginName); - if (!cfg.getBoolean("createNotes", true)) { + if (!cfg.getBoolean("createNotes", false)) { return; }
diff --git a/src/main/resources/Documentation/config.md b/src/main/resources/Documentation/config.md index b75fcaf..94f8703 100644 --- a/src/main/resources/Documentation/config.md +++ b/src/main/resources/Documentation/config.md
@@ -80,7 +80,7 @@ user. This allows to find a real person that is responsible for this commit. To get such a Git note for each commit of a service user the 'Forge Committer' access right must be blocked for service - users. By default true. + users. By default false. <a id="createNotesAsync"></a> `plugin.@PLUGIN@.createNotesAsync`