commit 2c43f60297255ef12c36e8a3648f3a873c1deae9
author Antonio Barone <syntonyze@gmail.com> Thu Mar 09 17:21:05 2023 +0100
committer Antonio Barone <syntonyze@gmail.com> Tue Mar 21 15:33:32 2023 +0100
tree ae935eac93795544781a4697358264e31dce7d27
parent c24049262c4bb669ae11cd7e473358df38c04f1c

Fix warm-cache accounts runtime error

Running warm-cache for accounts and groups-backends fails with

No signature of method:
com.google.gerrit.reviewdb.server.DisallowReadFromChangesReviewDbWrapper.accounts()
is applicable for argument types: () values: []

Fix this by using the Accounts object directly

Change-Id: I1a67a70e3a4654cfd191cf35ecd1e427a1a020ac

admin/warm-cache-1.0.groovy

diff --git a/admin/warm-cache-1.0.groovy b/admin/warm-cache-1.0.groovy
index eb1df2c..f5f9955 100644
--- a/admin/warm-cache-1.0.groovy
+++ b/admin/warm-cache-1.0.groovy
@@ -19,7 +19,6 @@
 import com.google.gerrit.server.account.*
 import com.google.gerrit.server.IdentifiedUser
 import com.google.gerrit.reviewdb.client.AccountGroup
-import com.google.gerrit.reviewdb.server.ReviewDb
 import com.google.inject.*
 import org.kohsuke.args4j.*
 
@@ -117,16 +116,15 @@
   AccountCache cache
 
   @Inject
-  Provider<ReviewDb> db
+  Accounts accounts
 
   public void run() {
     println "Loading accounts ..."
     def start = System.currentTimeMillis()
-    def allAccounts = db.get().accounts().all()
     def loaded = 0
 
-    for (account in allAccounts) {
-      cache.get(account.accountId)
+    for (accountId in accounts.allIds()) {
+      cache.get(accountId)
       loaded++
       if (loaded%1000==0) {
         println "$loaded accounts"
@@ -148,13 +146,13 @@
   public void run() {
     println "Loading groups ..."
     def start = System.currentTimeMillis()
-    def allAccounts = db.get().accounts().all()
+
     def loaded = 0
     def allGroupsUUIDs = new HashSet<AccountGroup.UUID>()
     def lastDisplay = 0
 
-    for (account in allAccounts) {
-      def user = userFactory.create(account.accountId)
+    for (accountId in accounts.allIds()) {
+      def user = userFactory.create(accountId)
       def groupsUUIDs = user?.getEffectiveGroups()?.getKnownGroups()
       if (groupsUUIDs != null) { allGroupsUUIDs.addAll(groupsUUIDs) }