commit 70f1f3a860fe9e276a3ed216bf2b179ea0e8cde3
author David Pursehouse <dpursehouse@collab.net> Mon May 27 13:58:31 2019 +0900
committer David Pursehouse <dpursehouse@collab.net> Mon May 27 13:58:31 2019 +0900
tree b8f0eecd792a9fa76d11c9c99e3ddb35ab12f639
parent 2091fdfc99f2cec60ae3fda2538ae1993b0fc8b8

ExportReviewNotes: Fix synchronization on non-final field

When all error prone warnings are enabled the SynchronizeOnNonFinalField
bug pattern is reported:

  plugins/reviewnotes/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/ExportReviewNotes.java:110:
  error: [SynchronizeOnNonFinalField] Synchronizing on non-final fields is not safe:
  if the field is ever updated, different threads may end up locking on different objects.
    synchronized (changes) {
                 ^
    (see https://errorprone.info/bugpattern/SynchronizeOnNonFinalField)

Change-Id: Ie671af628f1ce60de53165048b80d88e2c4d26ae