commit | 1fc1b6a6a51ea0210f0b224bd8cd48409163186f | [log] [tgz] |
---|---|---|
author | Nasser Grainawi <nasser@codeaurora.org> | Fri Jul 31 11:22:02 2020 -0600 |
committer | Nasser Grainawi <nasser@codeaurora.org> | Wed Aug 12 11:02:35 2020 -0600 |
tree | f977d3a68ec6e7a4a30cdbed784d3d24adf40326 | |
parent | d3cb4ca519f1f7372aa35ea356d2a7fb48865b1b [diff] |
TasksStorage: Replace delete() with start()+finish() in tests During the merge of stable-3.0, the delete() method was re-added [1] to fix a test that relied upon it. Instead, that test should have been updated to use the start() and finish() methods that are part of the public API for ReplicationTasksStorage. To facilitate that update, modify the start(), reset(), and finish() methods to not require a PushOne object. These methods can instead use a new interface that PushOne already can implement without functional changes. This interface avoids duplicate code in ReplicationTasksStorage. [1] https://gerrit-review.googlesource.com/c/plugins/replication/+/273660/-1..4/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorage.java Change-Id: Id82d2ec3125075832134c8dbe56b342e5a874bbc