Suppress UnnecessaryAssignment in withBaseOnly factory method withBaseOnly() intentionally assigns an @Inject field to support an alternate construction path. Suppress Error Prone's UnnecessaryAssignment warning for this method. Change-Id: I30cc92f830d562d87bd0437d8ac374ed0a2f7295
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/MergedConfigResource.java b/src/main/java/com/googlesource/gerrit/plugins/replication/MergedConfigResource.java index 58a10f0..541b0f4 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/MergedConfigResource.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/MergedConfigResource.java
@@ -34,8 +34,11 @@ public class MergedConfigResource { @VisibleForTesting @UsedAt(Project.PLUGIN_PULL_REPLICATION) + @SuppressWarnings("UnnecessaryAssignment") public static MergedConfigResource withBaseOnly(ConfigResource base) { MergedConfigResource mergedConfigResource = new MergedConfigResource(); + // This assigns an @Inject field explicitly, which is intentional here. + // Suppress UnnecessaryAssignment as DI is bypassed on this code path. mergedConfigResource.baseConfigProvider = Providers.of(base); return mergedConfigResource; }