commit 433aeac1bf6b85abe7a5e55a3033448b459ae6bf
author David Pursehouse <dpursehouse@collab.net> Mon May 27 14:04:31 2019 +0900
committer David Pursehouse <dpursehouse@collab.net> Mon May 27 14:05:11 2019 +0900
tree 52f8591fed3d482b83502b5517a0fc59fe3fba65
parent aa07963def69e4423444a078a662072e09629cec

Destination: Reviewers: Suppress FutureReturnValueIgnored warning

When all error prone warnings are enabled the FutureReturnValueIgnored
bug pattern is reported, for example:

  plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:367:
  error: [FutureReturnValueIgnored] Return value of methods returning Future must be checked.
  Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
        pool.schedule(e, now ? 0 : config.getDelay(), TimeUnit.SECONDS);
                     ^
    (see https://errorprone.info/bugpattern/FutureReturnValueIgnored)
  Did you mean to remove this line?

Change-Id: I43b5c3c9f9bf8cda5f2d4ee701b2153e7e6f2807

src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java b/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
index c5a11c8..f7bd01d 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
@@ -69,6 +69,7 @@
 import java.util.Set;
 import java.util.concurrent.Callable;
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
 import java.util.concurrent.TimeUnit;
 import org.apache.commons.io.FilenameUtils;
 import org.apache.http.impl.client.CloseableHttpClient;
@@ -364,7 +365,9 @@
         e = opFactory.create(project, uri);
         addRef(e, ref);
         e.addState(ref, state);
-        pool.schedule(e, now ? 0 : config.getDelay(), TimeUnit.SECONDS);
+        @SuppressWarnings("unused")
+        ScheduledFuture<?> ignored =
+            pool.schedule(e, now ? 0 : config.getDelay(), TimeUnit.SECONDS);
         pending.put(uri, e);
       } else if (!e.getRefs().contains(ref)) {
         addRef(e, ref);
@@ -383,11 +386,15 @@
   }
 
   void scheduleDeleteProject(URIish uri, Project.NameKey project) {
-    pool.schedule(deleteProjectFactory.create(uri, project), 0, TimeUnit.SECONDS);
+    @SuppressWarnings("unused")
+    ScheduledFuture<?> ignored =
+        pool.schedule(deleteProjectFactory.create(uri, project), 0, TimeUnit.SECONDS);
   }
 
   void scheduleUpdateHead(URIish uri, Project.NameKey project, String newHead) {
-    pool.schedule(updateHeadFactory.create(uri, project, newHead), 0, TimeUnit.SECONDS);
+    @SuppressWarnings("unused")
+    ScheduledFuture<?> ignored =
+        pool.schedule(updateHeadFactory.create(uri, project, newHead), 0, TimeUnit.SECONDS);
   }
 
   private void addRef(PushOne e, String ref) {
@@ -465,7 +472,9 @@
         pending.put(uri, pushOp);
         switch (reason) {
           case COLLISION:
-            pool.schedule(pushOp, config.getRescheduleDelay(), TimeUnit.SECONDS);
+            @SuppressWarnings("unused")
+            ScheduledFuture<?> ignored =
+                pool.schedule(pushOp, config.getRescheduleDelay(), TimeUnit.SECONDS);
             break;
           case TRANSPORT_ERROR:
           case REPOSITORY_MISSING:
@@ -477,7 +486,9 @@
             postReplicationFailedEvent(pushOp, status);
             if (pushOp.setToRetry()) {
               postReplicationScheduledEvent(pushOp);
-              pool.schedule(pushOp, config.getRetryDelay(), TimeUnit.MINUTES);
+              @SuppressWarnings("unused")
+              ScheduledFuture<?> ignored2 =
+                  pool.schedule(pushOp, config.getRetryDelay(), TimeUnit.MINUTES);
             } else {
               pushOp.canceledByReplication();
               pending.remove(uri);