Fix CredentialsFactory and CredentialsProvider abstraction leak

The CredentialsFactory returned SecureCredentialsProvider implementation
class instead of the abstract interface CredentialsProvider.

The SecureCredentialsProvider exposed its getUser and getPass methods
which were used by the replication plugin and thus hardcoded
username/password authentication for the REST API based admin
operations.

Fix the CredentialsFactory to create CredentialsProvider. Remove the
getUser and getPass methods from the SecureCredentialsProvider. Use the
abstract CredentialItem to get username and password from the
CredentialsProvider.

Change-Id: I8b6ef89694db4b7fd6e3116e69f562133f6ad5e8
4 files changed
tree: be0ad369288293308b9a5adf4108277e4a9eb06e
  1. .settings/
  2. src/
  3. .gitignore
  4. .mailmap
  5. BUILD
  6. LICENSE