Add tests for RateLimitUploadListener
Change-Id: Id542bef72f3881693c0f2c99d9198f9a25d2fb6b
diff --git a/BUCK b/BUCK
index 4d527fb..29f4337 100644
--- a/BUCK
+++ b/BUCK
@@ -1,4 +1,5 @@
include_defs('//bucklets/gerrit_plugin.bucklet')
+include_defs('//bucklets/maven_jar.bucklet')
gerrit_plugin(
name = 'quota',
@@ -14,7 +15,8 @@
)
TEST_DEPS = GERRIT_PLUGIN_API + GERRIT_TESTS + [
- ':quota__plugin'
+ ':quota__plugin',
+ ':mockito'
]
java_library(
@@ -28,3 +30,30 @@
labels = ['quota'],
deps = TEST_DEPS,
)
+
+maven_jar(
+ name = 'mockito',
+ id = 'org.mockito:mockito-core:2.7.21',
+ sha1 = '23e9f7bfb9717e849a05b84c29ee3ac723f1a653',
+ license = 'DO_NOT_DISTRIBUTE',
+ deps = [
+ ':byte-buddy',
+ ':objenesis',
+ ],
+)
+
+maven_jar(
+ name = 'byte-buddy',
+ id = 'net.bytebuddy:byte-buddy:1.6.11',
+ sha1 = '8a8f9409e27f1d62c909c7eef2aa7b3a580b4901',
+ license = 'DO_NOT_DISTRIBUTE',
+ attach_source = False,
+)
+
+maven_jar(
+ name = 'objenesis',
+ id = 'org.objenesis:objenesis:2.5',
+ sha1 = '612ecb799912ccf77cba9b3ed8c813da086076e9',
+ license = 'DO_NOT_DISTRIBUTE',
+ attach_source = False,
+)
diff --git a/src/test/java/com/googlesource/gerrit/plugins/quota/RateLimitUploadListenerTest.java b/src/test/java/com/googlesource/gerrit/plugins/quota/RateLimitUploadListenerTest.java
new file mode 100644
index 0000000..a6f2a47
--- /dev/null
+++ b/src/test/java/com/googlesource/gerrit/plugins/quota/RateLimitUploadListenerTest.java
@@ -0,0 +1,127 @@
+// Copyright (C) 2017 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.googlesource.gerrit.plugins.quota;
+
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import com.google.common.cache.LoadingCache;
+import com.google.common.util.concurrent.RateLimiter;
+import com.google.gerrit.reviewdb.client.Account;
+import com.google.gerrit.server.CurrentUser;
+import com.google.gerrit.server.validators.ValidationException;
+import com.google.inject.Provider;
+import com.googlesource.gerrit.plugins.quota.Module.Holder;
+import java.util.concurrent.ExecutionException;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Answers;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+
+@RunWith(MockitoJUnitRunner.class)
+public class RateLimitUploadListenerTest {
+ private static final String LIMIT_EXCEEDED_MSG = "test exceeded message: {0,number,##.##}";
+ private static final String REMOTE_HOST = "host";
+ private RateLimitUploadListener uploadHook;
+ @Mock private Provider<CurrentUser> user;
+ @Mock private LoadingCache<Account.Id, Holder> limitsPerAccount;
+ @Mock private LoadingCache<String, Holder> limitsPerRemoteHost;
+
+ @Mock(answer = Answers.RETURNS_DEEP_STUBS)
+ private CurrentUser currentUser;
+
+ @Mock private Account.Id accountId;
+ @Mock private Holder holder;
+ @Mock private RateLimiter limiter;
+
+ @Before
+ public void setUp() {
+ uploadHook =
+ spy(
+ new RateLimitUploadListener(
+ user, limitsPerAccount, limitsPerRemoteHost, LIMIT_EXCEEDED_MSG));
+ when(user.get()).thenReturn(currentUser);
+ }
+
+ private void setUpRegisteredUser() throws ExecutionException {
+ when(currentUser.isIdentifiedUser()).thenReturn(true);
+ when(currentUser.asIdentifiedUser().getAccountId()).thenReturn(accountId);
+ when(limitsPerAccount.get(accountId)).thenReturn(holder);
+ when(holder.get()).thenReturn(limiter);
+ }
+
+ private void setUpRegisteredUserExecutionException() throws ExecutionException {
+ when(currentUser.isIdentifiedUser()).thenReturn(true);
+ when(currentUser.asIdentifiedUser().getAccountId()).thenReturn(accountId);
+ when(limitsPerAccount.get(accountId)).thenThrow(new ExecutionException(null));
+ when(accountId.toString()).thenReturn("123");
+ }
+
+ private void setUpAnonymous() throws ExecutionException {
+ when(currentUser.isIdentifiedUser()).thenReturn(false);
+ when(limitsPerRemoteHost.get(REMOTE_HOST)).thenReturn(holder);
+ when(holder.get()).thenReturn(limiter);
+ }
+
+ private void setUpNoQuotaViolation() {
+ when(limiter.tryAcquire()).thenReturn(true);
+ }
+
+ private void setUpQuotaViolation() {
+ when(limiter.tryAcquire()).thenReturn(false);
+ }
+
+ @Test(expected = RateLimitException.class)
+ public void testNegotiationQuotaViolation() throws ExecutionException, ValidationException {
+ setUpRegisteredUser();
+ setUpQuotaViolation();
+ uploadHook.onBeginNegotiate(null, null, REMOTE_HOST, null, null, 0);
+ }
+
+ @Test
+ public void testNegotiationNoQuotaViolation() throws ExecutionException, ValidationException {
+ setUpRegisteredUser();
+ setUpNoQuotaViolation();
+ uploadHook.onBeginNegotiate(null, null, REMOTE_HOST, null, null, 0);
+ verify(limiter, times(0)).getRate();
+ }
+
+ @Test
+ public void testNegotiationCacheMiss() throws ExecutionException, ValidationException {
+ setUpRegisteredUserExecutionException();
+ uploadHook.onBeginNegotiate(null, null, REMOTE_HOST, null, null, 0);
+ verify(limiter, times(0)).getRate();
+ }
+
+ @Test(expected = RateLimitException.class)
+ public void testNegotiationAnonymQuotaViolation() throws ExecutionException, ValidationException {
+ setUpAnonymous();
+ setUpQuotaViolation();
+ uploadHook.onBeginNegotiate(null, null, REMOTE_HOST, null, null, 0);
+ }
+
+ @Test
+ public void testNegotiationAnonymNoQuotaViolation()
+ throws ExecutionException, ValidationException {
+ setUpAnonymous();
+ setUpNoQuotaViolation();
+ uploadHook.onBeginNegotiate(null, null, REMOTE_HOST, null, null, 0);
+ verify(limiter, times(0)).getRate();
+ }
+}
