commit d0aee3d5b5aa4e4676bc1c3979cd6c26114fdc58
author Luca Milanesio <luca.milanesio@gmail.com> Fri Aug 05 21:46:58 2022 +0200
committer Luca Milanesio <luca.milanesio@gmail.com> Fri Aug 05 20:20:32 2022 +0000
tree f2dc3268b8de00dcbbc492ff9809f5d262a1de1d
parent 6531c93b90d4d67767c912a35aff2b1c1ebb0ed8

Fix the processing of an empty HTML response body from REST-API

Change-Id: I23ce1b256b732ed10d6007e69bdc2179a8702dad

src/main/java/com/googlesource/gerrit/plugins/replication/pull/client/FetchRestApiClient.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/client/FetchRestApiClient.java b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/client/FetchRestApiClient.java
index 4db4ceb..2dd991c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/client/FetchRestApiClient.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/client/FetchRestApiClient.java
@@ -198,13 +198,20 @@
 
   @Override
   public HttpResult handleResponse(HttpResponse response) {
-    Optional<String> responseBody = Optional.empty();
 
-    try {
-      responseBody = Optional.ofNullable(EntityUtils.toString(response.getEntity()));
-    } catch (ParseException | IOException e) {
-      logger.atSevere().withCause(e).log("Unable get response body from %s", response.toString());
-    }
+    Optional<String> responseBody =
+        Optional.ofNullable(response.getEntity())
+            .flatMap(
+                body -> {
+                  try {
+                    return Optional.of(EntityUtils.toString(body));
+                  } catch (ParseException | IOException e) {
+                    logger.atSevere().withCause(e).log(
+                        "Unable get response body from %s", response.toString());
+                    return Optional.empty();
+                  }
+                });
+
     return new HttpResult(response.getStatusLine().getStatusCode(), responseBody);
   }