a0974cb6972478a8f8253188024a48c05b87c646 - plugins/pull-replication

commit: a0974cb6972478a8f8253188024a48c05b87c646
[log] [tgz]
author: Christoforos Miliotis <christoforos.miliotis.dev@gmail.com>
Fri Apr 28 12:12:57 2023 +0100
committer: Christoforos Miliotis <christoforos.miliotis.dev@gmail.com>
Wed May 17 08:08:47 2023 +0000
tree: 27fdbb4bde030743934eac5ef6d80e9aa998a289
parent: 9154d06c1e449ea1f8c248562b749192008db40b [diff]

Return a 404 on ResourceNotFoundException

Current implementation returns a 500, which is incorrect.
A ResourceNotFoundException indicates a resource could not
be found, which is REST translates to a 404 http code.

Returning a 404 will ensure that clients will be able
to correctly identify missing projects.

Bug: Issue 16730
Change-Id: Ifb331dcee7165b7b2f2b33879c6c3cd2edfe8cc2

src/main/java/com/googlesource/gerrit/plugins/replication/pull/api/PullReplicationFilter.java[diff]
src/test/java/com/googlesource/gerrit/plugins/replication/pull/api/PullReplicationFilterTest.java[diff]

2 files changed

tree: 27fdbb4bde030743934eac5ef6d80e9aa998a289

example-setup/
src/
.gitignore
BUILD
external_plugin_deps.bzl
Jenkinsfile
LICENSE