commit 8a530b699100be3b670a97c17e269b1e5f486352
author Luca Milanesio <luca.milanesio@gmail.com> Tue Oct 17 22:38:42 2023 +0100
committer Luca Milanesio <luca.milanesio@gmail.com> Tue Oct 17 22:38:42 2023 +0100
tree cb156d0a2a9f30208e00dcf5183eb3b8432032f4
parent 42c4ad01467a63961f065c50ded1502954beb6af

Remove exception PermissionBackendException from PullReplicationFilter

The PermissionBackendException exception was declared but not actually
thrown anywhere in the PullReplicationFilter.

Remove its declaration in the list of exception thrown in all
methods of PullReplicationFilter.

Change-Id: I96e767541c9883e2595aa95e2ea044a8a1d21052

src/main/java/com/googlesource/gerrit/plugins/replication/pull/api/PullReplicationFilter.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/api/PullReplicationFilter.java b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/api/PullReplicationFilter.java
index 5127311..7b086a7 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/api/PullReplicationFilter.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/api/PullReplicationFilter.java
@@ -42,7 +42,6 @@
 import com.google.gerrit.json.OutputFormat;
 import com.google.gerrit.server.AnonymousUser;
 import com.google.gerrit.server.CurrentUser;
-import com.google.gerrit.server.permissions.PermissionBackendException;
 import com.google.gerrit.server.project.ProjectCache;
 import com.google.gerrit.server.project.ProjectResource;
 import com.google.gerrit.server.project.ProjectState;
@@ -213,7 +212,7 @@
 
   @SuppressWarnings("unchecked")
   private Response<String> doApplyObject(HttpServletRequest httpRequest)
-      throws RestApiException, IOException, PermissionBackendException {
+      throws RestApiException, IOException {
     RevisionInput input = readJson(httpRequest, TypeLiteral.get(RevisionInput.class).getType());
     IdString id = getProjectName(httpRequest).get();
 
@@ -222,7 +221,7 @@
 
   @SuppressWarnings("unchecked")
   private Response<String> doApplyObjects(HttpServletRequest httpRequest)
-      throws RestApiException, IOException, PermissionBackendException {
+      throws RestApiException, IOException {
     RevisionsInput input = readJson(httpRequest, TypeLiteral.get(RevisionsInput.class).getType());
     IdString id = getProjectName(httpRequest).get();
 
@@ -231,7 +230,7 @@
 
   @SuppressWarnings("unchecked")
   private Response<Map<String, Object>> doBatchApplyObject(HttpServletRequest httpRequest)
-      throws RestApiException, IOException, PermissionBackendException {
+      throws RestApiException, IOException {
     TypeToken<List<RevisionInput>> collectionType = new TypeToken<>() {};
     List<RevisionInput> inputs = readJson(httpRequest, collectionType.getType());
     IdString id = getProjectName(httpRequest).get();
@@ -258,7 +257,7 @@
 
   @SuppressWarnings("unchecked")
   private Response<Map<String, Object>> doFetch(HttpServletRequest httpRequest)
-      throws IOException, RestApiException, PermissionBackendException {
+      throws IOException, RestApiException {
     Input input = readJson(httpRequest, TypeLiteral.get(Input.class).getType());
     IdString id = getProjectName(httpRequest).get();
 
@@ -275,7 +274,7 @@
 
   @SuppressWarnings("unchecked")
   private Response<Map<String, Object>> doBatchFetch(HttpServletRequest httpRequest)
-      throws IOException, RestApiException, PermissionBackendException {
+      throws IOException, RestApiException {
     TypeToken<List<Input>> collectionType = new TypeToken<>() {};
     List<Input> inputs = readJson(httpRequest, collectionType.getType());
     IdString id = getProjectName(httpRequest).get();