commit 80c124639c3119c4db932e804a443b85b6364267
author 姜浩哲 <jhzgg2017@gmail.com> Thu May 25 15:57:03 2023 +0800
committer Marcin Czech <maczech@gmail.com> Mon Sep 11 08:00:15 2023 +0000
tree 65b15ad14870b9f6a47eda0f0ef64ff016f2b0b3
parent 84989b0ff5308b7fea09e7f60af47d10c7cb23a3

Fix issue with using cgit client to fetch without authentication

CGit client passes empty username and password when not specified
in the configuration and this causes fetch operation failure.
To avoid the issue check if username/password is empty. If yes
skip git client authentication.

Bug: Issue 40015565
Change-Id: Ibf2569b2d3289a33386ff08e2aa7d30e546534ac
Signed-off-by: jianghaozhe <jhzgg2017@gmail.com>

src/main/java/com/googlesource/gerrit/plugins/replication/pull/fetch/CGitFetch.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/fetch/CGitFetch.java b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/fetch/CGitFetch.java
index 24898e6..d3e45da 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/fetch/CGitFetch.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/fetch/CGitFetch.java
@@ -28,6 +28,8 @@
 import java.util.List;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.eclipse.jgit.errors.TransportException;
 import org.eclipse.jgit.lib.RefUpdate;
 import org.eclipse.jgit.lib.Repository;
@@ -101,7 +103,9 @@
     if (credentialsProvider.supports(user, pass)
         && credentialsProvider.get(uri, user, pass)
         && uri.getScheme() != null
-        && !"ssh".equalsIgnoreCase(uri.getScheme())) {
+        && !"ssh".equalsIgnoreCase(uri.getScheme())
+        && StringUtils.isNotEmpty(user.getValue())
+        && ArrayUtils.isNotEmpty(pass.getValue())) {
       return uri.setUser(user.getValue()).setPass(String.valueOf(pass.getValue()));
     }