Google Git Google Git
Sign in
gerrit/plugins/owners-common-api/refs/heads/stable-3.15
commit
56b5112e3e3091ea3877683866795fae8551a089
[log]
author
Ewout Maertens <ewoutm@arista.com>
Sat Oct 17 11:00:39 2026 +1100
committer
Ewout Maertens <ewoutm@arista.com>
Fri Oct 16 17:08:23 2026 -0700
tree
588fe6995386dc6d23891208426bca8913b94154
parent
ea54d61718e1c3a4bf0744f587fd2161797d3018 [diff] 
Use internal server context for group member resolution

Replace the hardcoded Account.id(1000000) with
oneOffRequestContext.open() for resolving group membership in OWNERS
files. On instances where that account does not exist, hidden groups
silently return no members.

oneOffRequestContext.open() uses Gerrit's InternalUser, which bypasses
group visibility checks in GroupControl.canSeeMembers(). This is the
same approach used by findUserOrEmail() in this file.

Discussed in [1].

[1] https://groups.google.com/g/repo-discuss/c/1Kua6hWszDA/m/PSjubQ4zBAAJ

Change-Id: I66d2740ef3d228bc19889a1449d5bd0c98240451
1 file changed
tree: 588fe6995386dc6d23891208426bca8913b94154
  1. src/
  2. .gitignore
  3. BUILD
  4. external_plugin_deps.MODULE.bazel
  5. Jenkinsfile
  6. LICENSE
  7. MODULE.bazel
  8. MODULE.bazel.lock
  9. owners-common-api_plugin_deps.lock.json
  10. owners-common-api_third_party_runtime_jars.allowlist.txt
  11. README.md
README.md

Gerrit Owners-Common-API Plugin

This repository contains the basic infrastructure and API for building and running two separate plugins, owners and owners-autoassign.

It provides the ability to parse the OWNERS file format and it's parsing across branches and repositories.

Building the plugins

This plugin is built with Bazel in Gerrit tree

Create symbolic links of the owners-common-api folderd and of the external_plugin_deps.bzl file to the Gerrit source code /plugins directory.

Then build the owners-common-api plugin with the usual Gerrit plugin compile command.

Example:

  git clone https://gerrit.googlesource.com/plugins/owners-common-api
  git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
  cd gerrit/plugins
  ln -s ../../owners/owners-common-api .
  ln -sf owners-common-api/external_plugin_deps.bzl.MODULE.bazel .
  cd ..
  bazel build plugins/owners-common-api

The output is created in

  bazel-bin/plugins/owners-common-api/owners-common-api.jar

To execute the tests run:

  bazel test plugins/owners-common-api/...

This project can be imported into the Eclipse IDE:

Add the plugin name to the CUSTOM_PLUGINS (and in case when you want to run tests from the IDE to CUSTOM_PLUGINS_TEST_DEPS) in Gerrit core in tools/bzl/plugins.bzl file and run:

  ./tools/eclipse/project.py