| commit | 9580dfad35ff2b63c2f22e91830478e6450a5234 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Sat May 25 19:11:38 2019 +0200 |
| committer | David Ostrovsky <david@ostrovsky.org> | Wed May 29 23:20:24 2019 +0200 |
| tree | e80091ead937949b00f0ac77d9b4a0470f023abd | |
| parent | 76885ed960a6de39971e6ab5b48c615ec659e906 [diff] |
DefaultSharedRefEnforcement: Fix MutableConstantField warning
When all error prone warnings are enabled the MutableConstantField bug
pattern is reported:
DefaultSharedRefEnforcement.java:23: error: [MutableConstantField] \
Constant field declarations should use the immutable type (such as \
ImmutableList) instead of the general collection interface type (such \
as List)
private static final Map<String, EnforcePolicy> PREDEF_ENFORCEMENTS =
^
(see https://errorprone.info/bugpattern/MutableConstantField)
Change-Id: I7ab0d694c236cbcadb07b5efa1db0019f12be469
diff --git a/src/main/java/com/googlesource/gerrit/plugins/multisite/validation/dfsrefdb/DefaultSharedRefEnforcement.java b/src/main/java/com/googlesource/gerrit/plugins/multisite/validation/dfsrefdb/DefaultSharedRefEnforcement.java index 6b495fb..63bab09 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/multisite/validation/dfsrefdb/DefaultSharedRefEnforcement.java +++ b/src/main/java/com/googlesource/gerrit/plugins/multisite/validation/dfsrefdb/DefaultSharedRefEnforcement.java
@@ -16,11 +16,10 @@ import com.google.common.base.MoreObjects; import com.google.common.collect.ImmutableMap; -import java.util.Map; public class DefaultSharedRefEnforcement implements SharedRefEnforcement { - private static final Map<String, EnforcePolicy> PREDEF_ENFORCEMENTS = + private static final ImmutableMap<String, EnforcePolicy> PREDEF_ENFORCEMENTS = ImmutableMap.of("All-Users:refs/meta/external-ids", EnforcePolicy.DESIRED); @Override