Use Logger's built-in formatting where appropriate Change-Id: I80f41a9ef02ce2fd7db4eef4d16a75c327e6e6a8
diff --git a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsApiServlet.java b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsApiServlet.java index 4e20dd4..3c9b4cc 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsApiServlet.java +++ b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsApiServlet.java
@@ -132,9 +132,7 @@ String project = state.getProject().getName(); String userName = Strings.isNullOrEmpty(user.getUserName()) ? "anonymous" : user.getUserName(); - log.debug( - String.format( - "operation %s unauthorized for user %s on project %s", op, userName, project)); + log.debug("operation {} unauthorized for user {} on project {}", op, userName, project); throw new LfsUnauthorized(op, project); } }
diff --git a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsRepositoryResolver.java b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsRepositoryResolver.java index 914e638..5087976 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsRepositoryResolver.java +++ b/src/main/java/com/googlesource/gerrit/plugins/lfs/LfsRepositoryResolver.java
@@ -50,9 +50,9 @@ backend = backends.get(backendName); if (backend == null) { log.error( - String.format( - "Project %s is configured with not existing" + " backend %s", - project, Strings.isNullOrEmpty(backendName) ? DEFAULT : backendName)); + "Project {} is configured with not existing backend {}", + project, + Strings.isNullOrEmpty(backendName) ? DEFAULT : backendName); throw new LfsRepositoryNotFound(project.get()); } } @@ -64,9 +64,10 @@ // this is unlikely situation as cache is pre-populated from config but... log.error( - String.format( - "Project %s is configured with not existing" + " backend %s of type %s", - project, Strings.isNullOrEmpty(backendName) ? DEFAULT : backendName, backend.type)); + "Project {} is configured with not existing backend {} of type {}", + project, + Strings.isNullOrEmpty(backendName) ? DEFAULT : backendName, + backend.type); throw new LfsRepositoryNotFound(project.get()); } }
diff --git a/src/main/java/com/googlesource/gerrit/plugins/lfs/Lifecycle.java b/src/main/java/com/googlesource/gerrit/plugins/lfs/Lifecycle.java index 73302ad..ec386f1 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/lfs/Lifecycle.java +++ b/src/main/java/com/googlesource/gerrit/plugins/lfs/Lifecycle.java
@@ -49,10 +49,10 @@ private void warn(String msg) { log.warn( - String.format( - "%s; LFS will not be enabled. Run site initialization, or manually set" - + " lfs.plugin to '%s' in gerrit.config", - msg, name)); + "{}; LFS will not be enabled. Run site initialization, or manually set" + + " lfs.plugin to '{}' in gerrit.config", + msg, + name); } @Override