commit 8ee64cb6ba260019bc589c270a122daf076151f1
author David Ostrovsky <david@ostrovsky.org> Fri Jul 03 07:02:20 2020 +0200
committer David Ostrovsky <david@ostrovsky.org> Fri Jul 03 07:06:12 2020 +0200
tree a81c9f0e00663f1b176c841c7521b0d4254d3e25
parent 20bc2a6d086029c524bc16067e8722dc89e4115c

BugzillaItsFacadeTest: Migrate from easymock to mockito

Change-Id: I1c4d7de2a35ac08db4b81e7a7b416838aff08e38

src/test/java/com/googlesource/gerrit/plugins/its/bugzilla/BugzillaItsFacadeTest.java

diff --git a/src/test/java/com/googlesource/gerrit/plugins/its/bugzilla/BugzillaItsFacadeTest.java b/src/test/java/com/googlesource/gerrit/plugins/its/bugzilla/BugzillaItsFacadeTest.java
index 53b194e..2ad78e3 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/its/bugzilla/BugzillaItsFacadeTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/its/bugzilla/BugzillaItsFacadeTest.java
@@ -13,7 +13,8 @@
 // limitations under the License.
 package com.googlesource.gerrit.plugins.its.bugzilla;
 
-import static org.easymock.EasyMock.expect;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 
 import com.google.gerrit.extensions.annotations.PluginName;
 import com.google.gerrit.extensions.config.FactoryModule;
@@ -22,16 +23,20 @@
 import com.google.inject.Injector;
 import com.googlesource.gerrit.plugins.its.base.testutil.LoggingMockingTestCase;
 import org.eclipse.jgit.lib.Config;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.junit.MockitoJUnitRunner;
 
+@RunWith(MockitoJUnitRunner.class)
 public class BugzillaItsFacadeTest extends LoggingMockingTestCase {
   private Injector injector;
   private Config serverConfig;
 
+  @Test
   public void testCreateLinkForWebUiPlain() {
     mockUnconnectableBugzilla();
 
-    replayMocks();
-
     BugzillaItsFacade itsFacade = createBugzillaItsFacade();
     String actual = itsFacade.createLinkForWebui("Test-Url", "Test-Text");
 
@@ -42,11 +47,10 @@
     assertUnconnectableBugzilla();
   }
 
+  @Test
   public void testCreateLinkForWebUiUrlEqualsText() {
     mockUnconnectableBugzilla();
 
-    replayMocks();
-
     BugzillaItsFacade itsFacade = createBugzillaItsFacade();
     String actual = itsFacade.createLinkForWebui("Test-Url", "Test-Url");
 
@@ -56,11 +60,10 @@
     assertUnconnectableBugzilla();
   }
 
+  @Test
   public void testCreateLinkForWebUiUrlEqualsNull() {
     mockUnconnectableBugzilla();
 
-    replayMocks();
-
     BugzillaItsFacade itsFacade = createBugzillaItsFacade();
     String actual = itsFacade.createLinkForWebui("Test-Url", null);
 
@@ -75,9 +78,8 @@
   }
 
   private void mockUnconnectableBugzilla() {
-    expect(serverConfig.getString("its-bugzilla", null, "url")).andReturn("<no-url>").anyTimes();
-    expect(serverConfig.getString("its-bugzilla", null, "username")).andReturn("none").anyTimes();
-    expect(serverConfig.getString("its-bugzilla", null, "password")).andReturn("none").anyTimes();
+    when(serverConfig.getString("its-bugzilla", null, "url")).thenReturn("<no-url>");
+    when(serverConfig.getString("its-bugzilla", null, "username")).thenReturn("none");
   }
 
   private void assertUnconnectableBugzilla() {
@@ -87,6 +89,7 @@
   }
 
   @Override
+  @Before
   public void setUp() throws Exception {
     super.setUp();
 
@@ -96,7 +99,7 @@
   private class TestModule extends FactoryModule {
     @Override
     protected void configure() {
-      serverConfig = createMock(Config.class);
+      serverConfig = mock(Config.class);
       bind(Config.class).annotatedWith(GerritServerConfig.class).toInstance(serverConfig);
       bind(String.class).annotatedWith(PluginName.class).toInstance("its-bugzilla");
     }