commit | 25dbcb1a884c279ed0d14b44ff788617782466b6 | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Wed Mar 30 09:31:56 2022 +0200 |
committer | Ben Rohlfs <brohlfs@google.com> | Wed Mar 30 09:31:56 2022 +0200 |
tree | 1409d35dcfc1cf064db08b5df92bab68c3d7e33d | |
parent | 2c96c3c0db2fd3b8b1b0acdae2f1042c74dd9c8e [diff] |
Fix issues with calling Polymer.Debouncer On Google hosted Gerrit the image-diff plugin is broken. The error in the js console is: `Polymer.Debouncer.debounce is not a function` This has to do with the closure compilation, where the function ends up being renamed to `Debouncer$$module$third_party$javascript$polymer$v2$polymer$lib$utils$debounce$debounce` This plugin is in maintenance mode, so we are looking for a quick fix. Apparently the debouncing is not really required and can simply be removed. I have tested this with both Bazel and Blaze builds and the Dev Helper. Google-Bug-Id: b/217942160 Release-Notes: skip Change-Id: Ie183a3c1f68e9a2c2c1cd3a374d4d0231393afa0
A plugin that provides a rich image diffing experience in PolyGerrit. Currently, the plugin features two modes: Highlight Mode and Onion Skin.
These instructions will get you a copy of the project up and running on your local machine for development and testing purposes. See deployment for notes on how to deploy the project on a live system.
plugins
folder of gerrit
repo or link the plugin folder to gerrit/plugins
folderplugins/package.json
with package.json
, you can remove all depDependencies
as they are not needed for the build (needed for running wct tests)bazel build plugins/image-diff
This mode uses the Resemble.JS (1.2.1) library in its development The following features are included in this mode:
Onion Skin mode is a great way for users to notice changes in the images that might be overlooked when you look at them side by side. By overlaying the new image on top of the old image, the users can change the opacity to see the transition that were made.
The following features are included in this mode:
This plugin uses polymer-cli to test.
Inside your image-diff repo, run polymer serve
to start a local web server and open localhost:8080/test
to view your tests. See here for more info.
Or run npm run wct-test
to run all your tests.
Reference here on how to set up your Gerrit testsite and here for PolyGerrit plugin development.