RestForwarder: Tidy up debug logging

- Debug log is emitted with stack trace in both cases that the error
  is recoverable and unrecoverable. Move it out of the if-block.

- Mention the current attempt number and max retries in the error
  message, in the form "[1/5]".

- When the error is unrecoverable, mention it explicitly in the log.

- Explicitly add "giving up" in cases where the attempt is aborted.

- Since we now include the stack trace in all cases, don't include it
  on the "retrying" message.

Change-Id: Id8b0dc3a9900f7e76d265cbc2db7e61827e76de1
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
1 file changed