commit 8a66cd2eee6735c9f955839e9d9208ce784d0281
author Matthias Sohn <matthias.sohn@sap.com> Thu Mar 27 15:41:23 2025 +0100
committer Matthias Sohn <matthias.sohn@sap.com> Thu Mar 27 15:41:23 2025 +0100
tree 68ce6d068e06b0f0bc9674bad411b928d5c544b9
parent 656e705e786d41a2f6b9db9565c127ebc4f07679

First calculate elapsed time before logging error

since elapsed time shouldn't include time spent on logging the error.

Change-Id: I69bec59819d515c0456d6abc7a9933fffbedebcc

src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AbstractHealthCheck.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AbstractHealthCheck.java b/src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AbstractHealthCheck.java
index db0657e..0234e8f 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AbstractHealthCheck.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AbstractHealthCheck.java
@@ -101,8 +101,8 @@
   }
 
   private StatusSummary handleError(long ts, Exception e, String message, Result result) {
-    log.warn(message, e);
     Long elapsed = System.currentTimeMillis() - ts;
+    log.warn(message, e);
     StatusSummary checkStatusSummary =
         new StatusSummary(result, ts, elapsed, Collections.emptyMap());
     failureCounterMetric.increment();