Close Repository objects in RepositoryResolverAccessTest
Avoid false positives when looking for Repository
reference counting leaks by always closing the objects
after creation and assertions have completed.
Release-Notes: skip
Change-Id: Id30ec5876d165e96c5b95a2edbd5924b160e983d
diff --git a/src/test/java/com/googlesource/gerrit/plugins/gitiles/RepositoryResolverAccessTest.java b/src/test/java/com/googlesource/gerrit/plugins/gitiles/RepositoryResolverAccessTest.java
index 1f10177..a1cf436 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/gitiles/RepositoryResolverAccessTest.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/gitiles/RepositoryResolverAccessTest.java
@@ -69,9 +69,10 @@
gApi.projects().name(project.get()).branch("refs/heads/invisible").create(new BranchInput());
requestScopeOperations.setApiUserAnonymous();
- Repository repo = resolver().open(new FakeHttpServletRequest(), project.get());
- assertThat(repo.exactRef("refs/heads/visible")).isNotNull();
- assertThat(repo.exactRef("refs/heads/invisible")).isNull();
+ try (Repository repo = resolver().open(new FakeHttpServletRequest(), project.get())) {
+ assertThat(repo.exactRef("refs/heads/visible")).isNotNull();
+ assertThat(repo.exactRef("refs/heads/invisible")).isNull();
+ }
}
@Test
@@ -86,7 +87,9 @@
.update();
requestScopeOperations.setApiUser(user.id());
- assertThat(resolver().open(new FakeHttpServletRequest(), "visible")).isNotNull();
+ try (Repository visibleRepository = resolver().open(new FakeHttpServletRequest(), "visible")) {
+ assertThat(visibleRepository).isNotNull();
+ }
RepositoryNotFoundException ex =
assertThrows(
RepositoryNotFoundException.class,
