commit | cbc3f01080bd7c7467b359c8d6186f3a020de119 | [log] [tgz] |
---|---|---|
author | Luca Milanesio <luca.milanesio@gmail.com> | Sat Mar 01 23:08:19 2014 +0000 |
committer | Luca Milanesio <luca.milanesio@gmail.com> | Sun Mar 23 15:03:35 2014 +0000 |
tree | 9583bf592ccea65e38cda96b3856b607a24a3546 | |
parent | 89ec040b188525ecd9fd6e8146834db6ef54d6f0 [diff] |
ScopedProvider is now more similar to standard Guice's Provider By hiding the HttpServletRequest inside the HttpSessionProvider, the ScopedProvider<T> can be now 100% compatible with the standard Guice's Provider<T> interface. Moving as well from constructor injection to field injection so that the concrete implementation do not have to replicate the constructor injection definition. Code is more compact and extensible. The ability to get an instance by passing an actual HttpServletRequest is kept in order to allow the standard servlet filter (outside the Guice domain) to retrieve the object in the current session, without having to request a Provider<HttpServletRequest> which would fail. Change-Id: I20f32fc42ca05e9a4a140b64a1d5693d83ecf125
This plugin allows existing GitHub repositories to be integrated as Gerrit projects.
Many people see Gerrit and GitHub as opposites: the pull-request model adopted by GitHub is often used as “easy shortcut” to the more comprehensive and structured code-review process in Gerrit.
There are many discussion threads on this:
In reality there are already OpenSource projects that have started using the two tools together:
The reason for using GitHub and Gerrit together are: a) GitHub is widely recognised and accessible by lots of world-wide sites. b) Using a public GitHub repo allows to “off-load” a lot of git pull traffic. c) Pull-request allows novice users to start getting involved. d) Gerrit code-review define the quality gates for avoiding “noise” of unstructured contributions.
When using GitHub and Gerrit together, the “master of truth” has to be Gerrit: this is because it is the place where more control in terms of security and workflow can be defined.
A Gerrit plugin can help controlling the GitHub replica and importing the pull requests as Gerrit changes.
Users can login to Gerrit using the same username and credentials in GitHub. Gerrit login points to GitHub for generating the OAuth token to be used for the code-review authenticated session.
The initial Gerrit registration page can be customised to import GitHub SSH Keys directly into Gerrit.
Existing GitHub repositories are automatically replicated to Gerrit for the purpose of performing code-review and pushing back changes once approved. Additionally to the standard Gerrit push replication, supports as well the ability to pull branches from remote GitHub repositories.
Hooks into the GitHub pull-request mechanism to automatically create a Change in Gerrit submitted for review.
GitHub plugin is designed to work with Gerrit 2.8 (currently in development). In order to build the GitHub plugin you need to have a working Gerrit 2.8 build in place.
See https://gerrit-review.googlesource.com/Documentation/dev-buck.html for a reference on how to build Gerrit 2.8 (master branch) using BUCK.
In order to access GitHub API, we have used the lucamilanesio fork of Kohsuke API layer hosted on GitHub at https://github.com/lucamilanesio/github-api.
You need to clone and build the GitHub API as pre-requisite for building the GitHub plugin for Gerrit.
Example: git clone https://github.com/lucamilanesio/github-api.git cd github-api mvn install
You need to clone, build and install the singleusergroup plugin for Gerrit (see https://gerrit-review.googlesource.com/#/admin/projects/plugins/singleusergroup).
This plugin is needed to allow Gerrit to use individual users as Groups for being used in Gerrit ACLs.
Example: git clone https://gerrit.googlesource.com/plugins/singleusergroup cd singleusergroup mvn install cp target/singleusergroup-*.jar $GERRIT_SITE/plugins/.
Just clone the Git repository (see https://gerrit-review.googlesource.com/#/admin/projects/plugins/github) and do a mvn install
from the root directory. This will create two JARs under github-oauth/target and github-plugin/target: the oauth is a JAR library to be copied to $GERRIT_SITE/lib whilst the plugin JAR has to be installed as usual under $GERRIT_SITE/plugins.
Example: git clone https://gerrit.googlesource.com/plugins/github cd github mvn install cp target/github-oauth/target/github-oauth-.jar $GERRIT_SITE/lib cp target/github-plugin/target/github-plugin-.jar $GERRIT_SITE/plugins