Merge changes I81c2ec44,I342f74b0 * changes: FindBugs error: include encoding for wrapped login response FindBugs integration for detecting common errors
diff --git a/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/AuthenticatedLoginHttpResponse.java b/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/AuthenticatedLoginHttpResponse.java index 5e4b586..e9bd369 100644 --- a/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/AuthenticatedLoginHttpResponse.java +++ b/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/AuthenticatedLoginHttpResponse.java
@@ -15,6 +15,7 @@ import java.io.ByteArrayOutputStream; import java.io.IOException; +import java.io.OutputStreamWriter; import java.io.PrintWriter; import java.util.Collection; import java.util.Collections; @@ -174,7 +175,8 @@ @Override public PrintWriter getWriter() throws IOException { - return new PrintWriter(outputStream); + return new PrintWriter(new OutputStreamWriter(outputStream, + characterEncoding)); } @Override
diff --git a/pom.xml b/pom.xml index e4065cb..22bc8e0 100644 --- a/pom.xml +++ b/pom.xml
@@ -247,6 +247,15 @@ </plugin> </plugins> </build> + <reporting> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>3.0.0</version> + </plugin> + </plugins> + </reporting> <repositories> <repository> <releases>