Add RecursiveDeleteOption.ALLOW_INSECURE for recursive deletion

Otherwise unit tests are failing on osx with the following error:
JUnit4 Test Runner
...............log4j:WARN No appenders could be found for logger
  (org.eclipse.jgit.util.FS).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig
  for more info.
E......
Time: 1.255
There was 1 failure:
1) testStart(com.googlesource.gerrit.plugins.deleteproject.fs
  .DeleteTrashFoldersTest)
java.lang.AssertionError: The subject was expected to be false,
  but was true
    at com.googlesource.gerrit.plugins.deleteproject.fs
      .DeleteTrashFoldersTest.testStart(DeleteTrashFoldersTest.java:63)
      ...

which is caused by:
[2018-09-18 15:23:01,351] [DeleteTrashFolders] ERROR com.googlesource.gerrit
    .plugins.deleteproject.fs.DeleteTrashFolders :
  Failed to delete /.../repo.1234567890123.deleted
  com.google.common.io.InsecureRecursiveDeleteException:
    /.../repo.1234567890123.deleted:
    unable to guarantee security of recursive delete
    at com.google.common.io.MoreFiles
      .checkAllowsInsecure(MoreFiles.java:739)
    at com.google.common.io.MoreFiles
      .deleteRecursively(MoreFiles.java:525)
    at com.googlesource.gerrit.plugins.deleteproject.fs
      .DeleteTrashFolders
        .recursivelyDelete(DeleteTrashFolders.java:102)

Change-Id: Ic0894b88e912ef538796f6817065d974b28bc0a4
Signed-off-by: Jacek Centkowski <jcentkowski@collab.net>
1 file changed
tree: b2b7f8cb7bcaa009940a3a6438038e11bce917b8
  1. .settings/
  2. src/
  3. tools/
  4. .bazelrc
  5. .gitignore
  6. bazlets.bzl
  7. BUILD
  8. external_plugin_deps.bzl
  9. README.md
  10. WORKSPACE
README.md

Delete project plugin for Gerrit Code Review

A plugin which allows projects to be deleted from Gerrit via an SSH command, REST API or the Project settings screen.

Build Status