commit f40e83d739694779bf2950ce6c01969a8c926bb4
author Edwin Kempin <ekempin@google.com> Thu Mar 23 11:02:23 2023 +0100
committer Edwin Kempin <ekempin@google.com> Thu Mar 23 16:07:18 2023 +0100
tree 3c3a3976d49b214cd134b01dd249e13ae8efbdd1
parent 11299669add34bff0b4e4bdd617783946b5cb626

Post messages about code owner approved files asynchronously by default

When a code owner approves a change the code-owners plugin extends the
change message that Gerrit core posts for the approval to include the
paths that have been code-owner approved by the approval.

Computing the owned path is expensive, so this extension of the change
can be slow which goes at the expense of the post review latency.

To improve the post review latency we add a new configuration option to
post the approved path asynchronously in a separate change message and
turn this configuration on by default.

The new code-owner.enableAsyncMessageOnCodeOwnerApproval configuration
option follows the example of the existing
code-owners.enableAsyncMessageOnAddReviewer configuration which controls
whether the change message with paths owned by a newly added reviewer
should be posted asynchronously.

If asynchronous posting is enabled, 2 changes messages are posted when a
code owner applies an approval:

1. "Patch Set X: Code-Owner+1" posted by Gerrit core
2. "Patch Set X: By voting Code-Review+1 the following files are now
   code-owner approved by YYY: ..." posted by the code-owners plugin

If asynchronous posting is disabled, there is only a single change
message:

1. "Patch Set X: Code-Owner+1\n\nBy voting Code-Review+1 the following
   files are now code-owner approved by YYY: ..." posted by Gerrit core
   and extended by the code-owners plugin

Posting the change message asynchronously in OnCodeOwnerApproval follows
the example of how asynchronous posting is done in
CodeOwnersOnAddReviewer.

For running tests asynchronous message posting is disabled by default.
This is important to avoid LOCK_FAILUREs (see comment in
AbstractCodeOwnersTest.defaultConfig). So far disabling asynchronous
message posting for CodeOwnersOnAddReviewer was only relevant for
integration tests but the OnCodeOwnerApproval logic is also executed by
unit tests, hence we have to pull up this configuration from
AbstractCodeOwnersIT to AbstractCodeOwnersTest and add it to custom
default configs.

The asynchronous message posting is tested by a new test in
OnCodeOwnerApprovalIT which follows the example of the async test in
CodeOwnersOnAddReviewerIT.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I129e611afbb6384f10bd5a42dea43458273ed95d
Bug: Google b/273710181