Google Git
Sign in
gerrit / plugins / code-owners / c44765c7db4ce3972a130a65775fc440291e0d11
commitc44765c7db4ce3972a130a65775fc440291e0d11[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Thu Feb 10 09:17:50 2022 +0100
committerEdwin Kempin <ekempin@google.com>Thu Feb 10 09:21:48 2022 +0100
tree3ccf9b30fa437480db9d812d75daae860a7aefc6
parent6cb023a67dfb840c13fa3f7aadfc0063144e6674 [diff]
Test skipping code owner config validation when creating cherry pick via API

If a change / patch set is created via the Cherry Pick Revision REST
endpoint the code owner config file validation validates any OWNERS file
that is touched in the commit. This validation fails if such an OWNERS
file contains conflicts (conflicts are possible if
cherryPickInput.allowConflicts = true was set), since the conflict
markers in the file will be detected as invalid content.

Change I66dc4cfda in Gerrit core allows to set validation options in the
cherry pick input that are forwarded to the CommitValidationListeners.
This makes it possible to skip the code owner config validation when
creating a change via the Cherry Pick Revision REST endpoint, by
specifying code-owners~skip-validation=true as validation option.

This change adds a test to verify that skipping the code owner config
validation by setting code-owners~skip-validation=true in the cherry
pick input works.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I1f6b2f8a3ac1c821510f7ec8e294f01d72468abf
1 file changed
tree: 3ccf9b30fa437480db9d812d75daae860a7aefc6
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. test/
  6. ui/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

Also see resources/Documentation/about.md.

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md.

JavaScript Plugin

For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/ folder:

bazel build //plugins/code-owners/ui:code-owners
cp -f bazel-bin/plugins/code-owners/ui/code-owners.js plugins/

and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js to http://localhost:8081/plugins_/code-owners.js.