Validation: Log exceptions that happen in dry run mode of as a warning
The dry run mode allows to test the validation and it should be possible
to check that it's working before turning it on for real. The idea is to
know whether it's working by checkng the server log for exceptions that
happen during the validation. Unfortunately these exceptions were only
logged on fine level, so that they do not show up in server logs by
default. Raise the log level to warning so that the exceptions are
always logged and the dry run mode can be used as intended.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I9ba4460995c7447b4c59a5a15774a5d3ff6cf67f
diff --git a/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java b/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java
index 74dae62..f230eb9 100644
--- a/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java
+++ b/java/com/google/gerrit/plugins/codeowners/validation/CodeOwnerConfigValidator.java
@@ -202,7 +202,7 @@
// The validation was executed as dry-run and failures during the validation should not
// cause an error. Hence we swallow the exception here.
- logger.atFine().withCause(e).log(
+ logger.atWarning().withCause(e).log(
"ignoring failure during validation of code owner config files in revision %s"
+ " (project = %s, branch = %s) because the validation was performed as dry-run",
receiveEvent.commit.getName(),
