commit | d269abb77be5d19e04df34e08d89ac1d643236a8 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Thu Mar 04 14:51:26 2021 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Fri Mar 05 11:50:08 2021 +0100 |
tree | cbc9094f1843b1a56b8f8ac90c375cca45c34d47 | |
parent | bca9e7704f82284312998687c16a78252b0f9939 [diff] |
Compute only as many owned paths as needed, not all When a code owner approval is applied and when a code owner is added as a reviewer we post a change message that lists the owned paths. To avoid that the change messages get too large there is a configurable limit for the maximum number of paths that should be shown in change messages. If a user owns more paths the change message includes "(X more files)" to let the user know about this. For being able to post this message we are computing all paths of the change that are owned by the user. Computing owned path is rather expensive and if a change touches many files this increases the latency of the post review call. To improve the latency we are now limiting the computation of the owned paths to the number of paths that we are going to include into the change message, +1 to know if there are more owned files. This means that the change message can no longer say how many more owned files there are, but improving the latency seems more important than keeping this number included. If there are more owned files we will now only say "(more files)" to let the user know about this. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Id33722dc09144710758db5c84de4772656b9a4b5
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md.