| commit | 8bf495aa399d0dd3f2cf20f840b2406a48f7783f | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Mon May 17 14:52:25 2021 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Mon May 17 14:56:10 2021 +0000 |
| tree | ce5aa2dde281ec3cb12ae4d80a3baff8958bb05f | |
| parent | 2fd84e0fd10bfa05321d55b4c05a7c4e9a83f125 [diff] |
CodeOwnerApprovalCheck: Remove wrong shortcut for fallback code owners getFileStatusesForAccount(...) returned all files as approved if project owners were configured as fallback code owners and the given user was a project owner. Since fallback code owners are only applied for files for which no code owners have been defined, doing this was incorrect if a file had explcit code owners defined, but the given user was not amongst them. Since this was only a shortcut, we can simply drop it and the full computation will compute the correct status. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I686bf7340e59c6ff852459113d8a412903e82910
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md.