commit ba972b90e3dc5c8a98e13709a852e1ec0e393e20
author Edwin Kempin <ekempin@google.com> Thu Oct 22 15:35:07 2020 +0200
committer Edwin Kempin <ekempin@google.com> Thu Oct 22 15:38:58 2020 +0200
tree 197e37c9089625e271ca10313551f6e5010744e6
parent 492b4e01634aa5df858ea29abd279fe829d83b8c

CodeOwnerConfigValidatorIT: Test that code owner with allowed email domain can be added

When an allowed email domain is configured, we only tested that adding a
code owner with a non-allowed email domain is rejected, but we missed to
test that adding a code owner with an allowed email domain actually
works.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I240cfb73430024b0774c5b6d4f99bfb4e79e7a83

javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java

diff --git a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java
index 142c0ae..609411f 100644
--- a/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java
+++ b/javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerConfigValidatorIT.java
@@ -608,6 +608,24 @@
 
   @Test
   @GerritConfig(name = "plugin.code-owners.allowedEmailDomain", value = "example.com")
+  public void canUploadConfigThatAssignsCodeOwnershipToAnEmailWithAnAllowedEmailDomain()
+      throws Exception {
+    CodeOwnerConfig.Key codeOwnerConfigKey = createCodeOwnerConfigKey("/");
+
+    assertThat(admin.email()).endsWith("@example.com");
+    PushOneCommit.Result r =
+        createChange(
+            "Add code owners",
+            codeOwnerConfigOperations.codeOwnerConfig(codeOwnerConfigKey).getJGitFilePath(),
+            format(
+                CodeOwnerConfig.builder(codeOwnerConfigKey, TEST_REVISION)
+                    .addCodeOwnerSet(CodeOwnerSet.createWithoutPathExpressions(admin.email()))
+                    .build()));
+    assertOkWithHints(r, "code owner config files validated, no issues found");
+  }
+
+  @Test
+  @GerritConfig(name = "plugin.code-owners.allowedEmailDomain", value = "example.com")
   public void cannotUploadConfigThatAssignsCodeOwnershipToAnEmailWithANonAllowedEmailDomain()
       throws Exception {
     CodeOwnerConfig.Key codeOwnerConfigKey = createCodeOwnerConfigKey("/");