| commit | b6d59cca8098c61f01135305361dfa6661f3c91b | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Oct 08 11:21:06 2020 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Oct 08 11:24:29 2020 +0200 |
| tree | e5b9994617893d544101db9da523c0c7f873fed5 | |
| parent | 54e5deaf52e99da547875869ac70a06d95a407df [diff] |
CodeOwnerApprovalCheckTest: Make the approvedByGlobalCodeOwner more readable Looking at the test one could think that the file was already implictly approved by the admin user who creates the change and is a code owner. This is not the case since implicit approvals are disabled by default. However the test becomes more readable if we use a non-code-owner user to create the change. Add a verification that the file is not approved before the global code owner adds their approval. Also add some more comments to make the code easier to read. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ib626315a1ca5efdd9b2e5a066f878507606d1ad8
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md