Google Git
Sign in
gerrit / plugins / code-owners / b1a493dfe55fb28a10a246c7bc03847ad050cf38
commitb1a493dfe55fb28a10a246c7bc03847ad050cf38[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Tue Feb 02 18:08:31 2021 +0100
committerEdwin Kempin <ekempin@google.com>Tue Feb 02 18:17:20 2021 +0100
tree2b72592cf8443ef479e4d9fbf04f1d16fed7df70
parent72842529ff82d2c8d342e3fa7e0301092df2844b [diff]
Remove equals/hashCode/toString methods from info classes

Mostly these were unused. Only one test assertion in
CodeOwnerConfigInfoSubject required some of the equals methods, but we
can rewrite this so that it no longer relies on the equals methods.

Updating equals/hashCode/toString can easily be forgotten if there are
no dedicated tests for them (e.g. in CodeOwnerConfigInfo they did not
consider the ignoreParentCodeOwners field which was not noticed). Since
they are not really needed and writing tests for them is a hassle (there
are utilities for this, but they are currently not available in upstream
Gerrit) we just drop them.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I74048bb0d1848ebb25b8c7fb93b76114d0bd7b45
5 files changed
tree: 2b72592cf8443ef479e4d9fbf04f1d16fed7df70
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. test/
  6. ui/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

Also see resources/Documentation/about.md

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md