Google Git
Sign in
gerrit/plugins/code-owners/a3d7b93ec63c1e9217cc525a3ce8cf7df5985ba4
commit
a3d7b93ec63c1e9217cc525a3ce8cf7df5985ba4
[log]
author
Edwin Kempin <ekempin@google.com>
Fri Jan 08 11:30:29 2021 +0100
committer
Edwin Kempin <ekempin@google.com>
Mon Jan 11 15:19:24 2021 +0100
tree
82b01f5d1302477825d1df3d78b4c3d83501bf48
parent
02d36d4901fd58485c032d648e53831885e56d0e [diff]
Fix getAllUsersAsCodeOwners_allVisible test

This test was supposed to test the code for handling
accounts.visibility = ALL, but since the admin user was doing the call
we instead landed in the shortcut for users that have the
VIEW_ALL_ACCOUNTS capability (which is already covered by
getAllUsersAsCodeOwners_withViewAllAccounts).

This was discovered by looking at the test coverage. Fixing this
increases the test coverage for AbstractGetCodeOwnersForPath slightly
from 95.4% to 96.2%.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I1ef01100677586daf10581c3876a639bb313b009
1 file changed
tree: 82b01f5d1302477825d1df3d78b4c3d83501bf48
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. test/
  6. ui/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

Also see resources/Documentation/about.md

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md