| commit | 63b86f4f081e853f220c7f78426513b634d93254 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Oct 14 15:20:50 2020 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Oct 14 15:31:17 2020 +0200 |
| tree | b51445ec2d977dc8f66f60536e64bd898ba04f0f | |
| parent | cf6428c4c2732c7bc1fddba4235e68786f1c6478 [diff] |
GetCodeOwnerProjectConfig should not fail with 500 ISE if config is invalid If the plugin configuration is invalid we want to fail with 409 Conflict rather than 500 Internal Server Error. This is ensured by InvalidPluginConfigurationException.ExceptionHook which returns 409 Conflict if an exception is caused by InvalidPluginConfigurationException, but there was one case where an invalid configuration didn't throw this exception and hence the request failed with 500 ISE. This was the case if the default required approval (Code-Review+1) was used but the project didn't have the Code-Review label. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I76e6de49b089f211a03a81c52430296806b8fe5d
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md