Google Git
Sign in
gerrit / plugins / code-owners / 9241c3051cab78a12e60d4aa6efaa097da25ffcf
commit9241c3051cab78a12e60d4aa6efaa097da25ffcf[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Fri May 24 06:36:53 2024 +0000
committerPatrick Hiesel <hiesel@google.com>Fri May 24 07:36:30 2024 +0000
tree4af51a5cc83951202e61512cba30a113d8e1f1c2
parent386c77c539b5b38eb868f470594b2242e962a371 [diff]
Clarify that being able to approve changes doesn't make a user a code owner

Code owner approvals are applied by voting on a label. Which label
counts as a code owner approval is configurable. Sometimes users think
that being able to vote on that label makes them a code owner. Having
this permission is not sufficient, but to be considered as a code owner
users must be listed as a code owner in an OWNERS file. Add a note about
this to the documentation.

Release-Notes: skip
Change-Id: I39df35bb14ae81b6f6f2af69ed146a943924041d
Signed-off-by: Edwin Kempin <ekempin@google.com>
Reviewed-on: https://gerrit-review.googlesource.com/c/plugins/code-owners/+/426423
Tested-by: Zuul <zuul-63@gerritcodereview-ci.iam.gserviceaccount.com>
Reviewed-by: Patrick Hiesel <hiesel@google.com>
1 file changed
tree: 4af51a5cc83951202e61512cba30a113d8e1f1c2
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. web/
  6. .gitignore
  7. .gitreview
  8. BUILD
  9. LICENSE
  10. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

For a detailed description of the plugin functionality please refer to the plugin documentation.

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.

NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.

JavaScript Plugin

From the root of the gerrit repository.

bazel test //plugins/code-owners/web:karma_test

For testing the plugin with the Gerrit FE Dev Helper the command below builds

    bazel build //plugins/code-owners/web:code-owners
    ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/

and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js to http://localhost:8081/plugins/code-owners.js.