commit | 75798469c9c491913afaaf45f725b620ec6a7612 | [log] [tgz] |
---|---|---|
author | Chris Poucet <poucet@google.com> | Mon Dec 12 11:43:38 2022 +0100 |
committer | Chris Poucet <poucet@google.com> | Mon Dec 12 11:49:44 2022 +0100 |
tree | db410b7540a9cd9efdaa4bd383b17021d0832dda | |
parent | 25a6e411dc8a58ba2b39329c3f772e27ad0ad20d [diff] |
Compute owners for file-deletions correctly. Gerrit FE returns 'path' not 'oldPath' for deleted files. However, code-owners plugin computes deleted files as 'oldPath' not 'path'. To get around this difference in API, we check if oldPath is not set. In that case, we also check if path exists in the oldPaths returned by the code-owners plugin Additionally, uniquify accounts so we don't show duplicates. Google-Bug-Id: b/200008775 Change-Id: I268397ccf1ed5d89cfe03b64b42b917c67c80233
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
For a detailed description of the plugin functionality please refer to the plugin documentation.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.
NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.
From the root of the gerrit repository.
bazel test //plugins/code-owners/web:karma_test
For testing the plugin with the Gerrit FE Dev Helper the command below builds
bazel build //plugins/code-owners/web:code-owners ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/
and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js
to http://localhost:8081/plugins/code-owners.js
.