| commit | 5e7ad16beb960b6666817961e47b531eacc00445 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Jan 28 11:45:47 2021 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Jan 28 11:52:32 2021 +0100 |
| tree | d8f8ec390671077702f1970d24dc152fbf37c53c | |
| parent | c61d9c7747522de35e5859457c0fd8308b231d6e [diff] |
Document that code owner approvals always apply to all files in the change Code owners may be tempted to review only the files that they own, but this is not recommended since their approval counts for all files in the change (as voting is done on change level, not on file level). E.g. this is a problem if: * a change touches files A and B * a user owns file A, but not file B * the user reviews only file A and approves the change * the OWNERS files are changed so that the user owns file B too now * the approval that was given by the user on the change approves files A and B now, but the user actually didn't review file B Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I98af48fccefd1035795e833c23f0ee7415492a7c
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md