Google Git
Sign in
gerrit / plugins / code-owners / 4e47cbe5964772024261d01526be4e17b8132ef6
commit4e47cbe5964772024261d01526be4e17b8132ef6[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Mon Jun 17 11:00:18 2024 +0000
committerPatrick Hiesel <hiesel@google.com>Mon Jun 17 12:12:23 2024 +0000
treef9abacf3ed0929632cc7ac016ba02a1d9a78f29a
parent762423203fc1fe73ab66893b4ba3657488c1ffb4 [diff]
Fix usage of ChangedFilesByPatchSetCache

This caching didn't work because we created a new instance in the
callback that is invoked per file, rather than creating one instance and
using it for the whole request.

Note, this cache is only relevant when sticky code owner approvals are
enabled.

Change-Id: Ic2357878227e5f1ffac99530f0584d42b7f1ea3b
Signed-off-by: Edwin Kempin <ekempin@google.com>
Reviewed-on: https://gerrit-review.googlesource.com/c/plugins/code-owners/+/430377
Reviewed-by: Patrick Hiesel <hiesel@google.com>
Tested-by: Zuul <zuul-63@gerritcodereview-ci.iam.gserviceaccount.com>
1 file changed
tree: f9abacf3ed0929632cc7ac016ba02a1d9a78f29a
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. web/
  6. .gitignore
  7. .gitreview
  8. BUILD
  9. LICENSE
  10. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

For a detailed description of the plugin functionality please refer to the plugin documentation.

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.

NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.

JavaScript Plugin

From the root of the gerrit repository.

bazel test //plugins/code-owners/web:karma_test

For testing the plugin with the Gerrit FE Dev Helper the command below builds

    bazel build //plugins/code-owners/web:code-owners
    ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/

and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js to http://localhost:8081/plugins/code-owners.js.