| commit | 4a9c3a1e71ff7dd9f85cc8393dc63cb2908e5e59 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Mar 07 11:06:59 2024 +0000 |
| committer | Patrick Hiesel <hiesel@google.com> | Fri Mar 08 08:39:45 2024 +0000 |
| tree | 8592678753ee306135ced3e6fef84494c47952e9 | |
| parent | c63c8209e8bbc5058d9ec0451156efa038c170e0 [diff] |
Show that CodeOwnersSubmitRule is run twice when a Code-Owners SR is configured Add a test to show that the CodeOwnersSubmitRule is executed twice when a Code-Owners submit requirement is configured, once because the CodeOwnerSubmitRule implements the SubmitRule extension point and once because there is submit requirement configured that uses the CodeOwnerApprovalPredicate. CodeOwnerApprovalPredicate was added by change I391a0d7fd as part of replacing submit rules with submit requirements, but then submit rules were not migrated to submit requirements. Bug: Google b/325070428 Change-Id: I07f9ed1f0dff448b5b51d9dd232184648e88652a Signed-off-by: Edwin Kempin <ekempin@google.com> Reviewed-on: https://gerrit-review.googlesource.com/c/plugins/code-owners/+/412200 Tested-by: Zuul <zuul-63@gerritcodereview-ci.iam.gserviceaccount.com> Reviewed-by: Patrick Hiesel <hiesel@google.com>
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
For a detailed description of the plugin functionality please refer to the plugin documentation.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.
NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.
From the root of the gerrit repository.
bazel test //plugins/code-owners/web:karma_test
For testing the plugin with the Gerrit FE Dev Helper the command below builds
bazel build //plugins/code-owners/web:code-owners
ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/
and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js to http://localhost:8081/plugins/code-owners.js.