| commit | ad474fbfc4d55e0d0d68ecb7279449306778806b | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Sep 18 09:40:50 2025 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Sep 18 09:40:50 2025 +0000 |
| tree | 0e5a6e83ba6ec70f4932698d66aa5944a2dc0967 | |
| parent | 0f053870fb799ecb43261f1e47eccdb49b9dd91f [diff] |
Drop CodeOwnersInternalServerErrorException CodeOwnersInternalServerErrorException was added during the rollout of the code-owners feature to recognise issues with the code-owners plugin immediately. It's thrown for any exception that happens in the code-owners plugin, even if the error is not caused by the code-owners plugin, but happens in other Gerrit modules that are used by the code-owners plugin. For example if permissions cannot be evaluated and the PermissionBackend fails with a PermissionBackendException, anywhere in Gerrit that would result in a normal "internal server error", only if the caller is the code-owners plugin it is a "code-owners internal server error". This doesn't make sense, at least no longer since the code-owners rollout is long done. In retrospect wrapping arbitrary exceptions that happen in code that is called from the code-owners plugin into CodeOwnersInternalServerErrorException's caused more confusion than it helped because non-code-owner related errors were attributed to the code-owners plugin. Hence dropping this exception now. Instead we just use StorageException like in the rest of the Gerrit code. Change-Id: I77e7e2026de7a6c3a6eccd184fd20993dc81aa22 Signed-off-by: Edwin Kempin <ekempin@google.com>
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
For a detailed description of the plugin functionality please refer to the plugin documentation.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.
NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.
From the root of the gerrit repository.
bazel test //plugins/code-owners/web:karma_test
For testing the plugin with the Gerrit FE Dev Helper the command below builds
bazel build //plugins/code-owners/web:code-owners
ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/
and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js to http://localhost:8081/plugins/code-owners.js.