| commit | 2b51383e6f4a20b7019a94faa58543c5ccdbdd50 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Mon Dec 21 12:33:45 2020 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Jan 07 08:40:27 2021 +0100 |
| tree | 4edccdb783b623806fd2d3dff445422f7a47ccad | |
| parent | 37e7f9b30686891164b05f01396f43d2f8db738a [diff] |
FindOwnersBackend: Fix incompatibility of handling globs The find-owners backend promises to be compatible with the syntax of the find-owners plugin, but currently the handling of '*' in globs differs. The find-owners backend in the code-owners plugin currently handles '*'s in globs like this: * '*': matches any string that does not include slashes * '**': matches any string, including slashes This matches with how globs work in Java [1], however it is incompatible with the find-owners plugin that handles '*'s in globs like this: * '*'/'**': matches any string, including slashes Change the find-owners backend in the code-owners plugin to be compatible with the find-owners plugin. For this we simply replace any single '*' character that appears in globs with '**' before we check if the glob matches. [1] https://mincong.io/2019/04/16/glob-expression-understanding/ Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I1ddc8bf326bbcb8867ffd09eebc7a6739ad7d827
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md