commit | 23afa6492dbab8877c34bba2c9d6a45e6c1e8bf6 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Dec 04 11:34:42 2020 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Thu Dec 10 12:03:31 2020 +0100 |
tree | 950a3797b00153be85875e7be1ea2c8df246304c | |
parent | a590a7a2073d38586eff9db3e9fddb83fc92a8ee [diff] |
Allow to ignore self approvals for required approval If a label has ignoreSelfApproval set to true, self approvals from the uploader are ignored. However so far this flag was ignored for code owner approvals. This means the code owners check did pass if there was an approval from the uploader, even if ignoreSelfApproval was set to true. With this change now, any vote from the uploader is ignored for the code owners check if the required label has ignoreSelfApproval set to true. In this case the enableImplicitApprovals configuration is ignored because there can never be an implicit approval of the uploader if self approvals of the uploader are ignored. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I698a737bc2551e638c11b8cdd4ca3256fa3d45e0
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md