Allow to ignore self approvals for required approval

If a label has ignoreSelfApproval set to true, self approvals from the
uploader are ignored. However so far this flag was ignored for code
owner approvals. This means the code owners check did pass if there was
an approval from the uploader, even if ignoreSelfApproval was set to
true. With this change now, any vote from the uploader is ignored for
the code owners check if the required label has ignoreSelfApproval set
to true. In this case the enableImplicitApprovals configuration is
ignored because there can never be an implicit approval of the uploader
if self approvals of the uploader are ignored.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I698a737bc2551e638c11b8cdd4ca3256fa3d45e0
5 files changed
tree: 950a3797b00153be85875e7be1ea2c8df246304c
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. test/
  6. ui/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

Also see resources/Documentation/about.md

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md