commit 1ada8b31903e9594afd3b87d9648ec97efc60504
author Edwin Kempin <ekempin@google.com> Mon Jan 11 11:43:27 2021 +0100
committer Edwin Kempin <ekempin@google.com> Fri Jan 15 15:12:39 2021 +0100
tree 3ec38a4067019817d02c3a12d0931eb3a153f22e
parent d5e04c6df53810ce195efe28d56f6725013fe1dd

CodeOwnersOnPostReview: Log error if vote is not new, deleted or changed

If we reach this case, something is wrong and we want to know about it.
Hence log an error.

Also this makes the code more readable.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I5468a88c7da01d88d253170458be048287a0de0e

java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java

diff --git a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java
index 75f5c84..c26b821 100644
--- a/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java
+++ b/java/com/google/gerrit/plugins/codeowners/backend/CodeOwnersOnPostReview.java
@@ -182,7 +182,16 @@
                 newVote, user.getName()));
       }
     } else {
-      return Optional.empty();
+      logger.atSevere().log(
+          "code owner approval was neither newly applied, removed, upgraded nor downgraded:"
+              + " project = %s, change = %s, patch set = %d, oldApprvals = %s, approvals = %s,"
+              + " requiredApproval = %s",
+          changeNotes.getProjectName(),
+          changeNotes.getChangeId(),
+          patchSet.id().get(),
+          oldApprovals,
+          approvals,
+          requiredApproval);
     }
 
     if (ownedPaths.size() <= maxPathsInChangeMessage) {