commit | 05ab2424f130613194a7367398aa6cba6db98fbe | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Jul 12 08:03:57 2024 +0000 |
committer | Edwin Kempin <ekempin@google.com> | Fri Jul 12 11:01:33 2024 +0000 |
tree | a303f323aed39ed47018d9feb6c2ba33b0cbae50 | |
parent | d488c5978e4b95e30e8a914def58e62452119220 [diff] |
Respect the suggest.skipServiceUsers config when suggesting code owners By default Gerrit doesn't suggest service users, but this behavior can be overriden by setting suggest.skipServiceUsers=false in the gerrit config. When this setting was added the code-owners plugin was not adapted to respect it. Fix this now. Bug: Google b/352467354 Change-Id: I234fddf7386979e0848abd911cca9d85281e15fa Signed-off-by: Edwin Kempin <ekempin@google.com> Reviewed-on: https://gerrit-review.googlesource.com/c/plugins/code-owners/+/433118 Reviewed-by: Nitzan Gur-Furman <nitzan@google.com> Tested-by: Zuul <zuul-63@gerritcodereview-ci.iam.gserviceaccount.com>
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
For a detailed description of the plugin functionality please refer to the plugin documentation.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.
NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.
From the root of the gerrit repository.
bazel test //plugins/code-owners/web:karma_test
For testing the plugin with the Gerrit FE Dev Helper the command below builds
bazel build //plugins/code-owners/web:code-owners ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/
and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js
to http://localhost:8081/plugins/code-owners.js
.