commit f01a1f9f484cf3c04961c9a8fa25f2f419ec0fec
author Steffen Gebert <steffen.gebert@typo3.org> Tue May 14 08:56:17 2013 +0200
committer Steffen Gebert <steffen.gebert@typo3.org> Tue May 14 08:56:17 2013 +0200
tree b2e6a7dfa7cbe8712bd582dcfcd323ebb3d65276
parent 25aa349b5b3d0919adc15b1f1812b3d0fd8cfd1c

URLEncode the username

src/main/java/org/typo3/gerrit/plugins/avatars/typo3org/ExternalUrlAvatarProvider.java

diff --git a/src/main/java/org/typo3/gerrit/plugins/avatars/typo3org/ExternalUrlAvatarProvider.java b/src/main/java/org/typo3/gerrit/plugins/avatars/typo3org/ExternalUrlAvatarProvider.java
index 6545b2b..8f29462 100644
--- a/src/main/java/org/typo3/gerrit/plugins/avatars/typo3org/ExternalUrlAvatarProvider.java
+++ b/src/main/java/org/typo3/gerrit/plugins/avatars/typo3org/ExternalUrlAvatarProvider.java
@@ -29,6 +29,7 @@
 import org.slf4j.LoggerFactory;
 
 import java.io.UnsupportedEncodingException;
+import java.net.URLEncoder;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 
@@ -58,6 +59,14 @@
       return null;
     }
 
+    try {
+      username = URLEncoder.encode(username, "UTF-8");
+    } catch (UnsupportedEncodingException e) {
+      Logger log = LoggerFactory.getLogger(ExternalUrlAvatarProvider.class);
+      log.warn("Weird thing, UTF-8 as encoding is not supported");
+      return null;
+    }
+
     if (externalAvatarUrl == null) {
       Logger log = LoggerFactory.getLogger(ExternalUrlAvatarProvider.class);
       log.warn("Avatar URL is not configured, cannot show avatars. Please configure avatar.url in etc/gerrit.config");