commit d13cf82f01c9094a4b3bd8b81e662f597c2dd53e
author Saša Živkov <sasa.zivkov@sap.com> Tue Jan 28 14:14:02 2025 +0100
committer Saša Živkov <sasa.zivkov@sap.com> Tue Jan 28 14:14:02 2025 +0100
tree 57c3bdb79bc23552fd7a1fe549ab417f6561790c
parent 825a45311a3b4f1dbca4417ac9fcaa4359b827ad

Fix upperCaseUsername check

The string equality check was wrongly performed against the replacement
string instead of against the placeholder.

Change-Id: I12c01e185dd7919ff748d8180c86d6deb4437396

src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
index b2da42b..34b41e6 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
@@ -115,7 +115,7 @@
     if (url == null || replacement == null || !url.contains(placeholder)) {
       return url;
     }
-    if ("${user}".equals(replacement) && upperCaseUsername) {
+    if ("${user}".equals(placeholder) && upperCaseUsername) {
       replacement = replacement.toUpperCase();
     } else if (lowerCase) {
       replacement = replacement.toLowerCase();