Elasticsearch: Don't use JsonElement.toString
JsonElement.toString returns the value wrapped in an extra pair of
quotes, while getAsString does not.
The base64 decoder that we are currently using seems to be tolerant
of this, but others may not be which could cause issues.
Also, we already use getAsString in other places, so changing this
makes it consistent.
Change-Id: I42c71444782aa467321027856b017df62106c38c
diff --git a/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java b/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
index d206e88..2af6508 100644
--- a/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
+++ b/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
@@ -91,7 +91,7 @@
return null;
}
return FluentIterable.from(field)
- .transform(i -> codec.decode(decodeBase64(i.toString())))
+ .transform(i -> codec.decode(decodeBase64(i.getAsString())))
.toList();
}
diff --git a/java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java b/java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java
index 6914141..eabe6ba 100644
--- a/java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java
+++ b/java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java
@@ -417,7 +417,7 @@
}
ChangeField.parseSubmitRecords(
FluentIterable.from(records)
- .transform(i -> new String(decodeBase64(i.toString()), UTF_8))
+ .transform(i -> new String(decodeBase64(i.getAsString()), UTF_8))
.toList(),
opts,
out);
