commit 7fa3f06e86626d1dc1ceb3f55d814cfa26274a3f
author Kaushik Lingarkar <kaushik.lingarkar@linaro.org> Thu Sep 07 10:15:47 2023 -0700
committer Kaushik Lingarkar <kaushik.lingarkar@linaro.org> Fri Sep 22 18:15:08 2023 -0700
tree 2d4e75823fa7aa2e03c322c068f9e314f5eca2ac
parent 9fa64809c8c0b719e3a85af07f89ce8eb9d1ed0f

Index.replace: Log responses containing errors

Logging errors can help with triage.

Change-Id: Idefb8dacd0b3fb51f1006f947873dc92ffbd641f

src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java

diff --git a/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java b/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
index 1aac6e7..482868c 100644
--- a/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
+++ b/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
@@ -284,7 +284,11 @@
           String.format("Expected %s, but was: %s", ContentType.APPLICATION_JSON, contentType));
       String responseStr = EntityUtils.toString(response.getEntity());
       JsonObject responseJson = (JsonObject) new JsonParser().parse(responseStr);
-      return responseJson.get("errors").getAsBoolean();
+      boolean hasErrors = responseJson.get("errors").getAsBoolean();
+      if (hasErrors) {
+        logger.atSevere().log("Response with errors: %s", responseJson);
+      }
+      return hasErrors;
     } catch (IOException e) {
       throw new StorageException(e);
     }