HttpClientConnectionTest: Throw UnsupportedOperationException for unused methods The HttpResponseMock class is only used in a single test to assert on the expected headers. All of its overridden methods are empty, and this results in warnings in Eclipse: 'Empty block should be documented' Rather than adding "// Not used" comments, change all of the methods' implementations to throw UnsupportedOperationException. This not only gets rid of the warnings, but also makes it explicit that we don't intend any of them to actually be called. Change-Id: I8fe06b155e0809bb3507e4e28b00fcc4f9333b0b Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/transport/http/apache/HttpClientConnectionTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/transport/http/apache/HttpClientConnectionTest.java index f43bce7..72c4921 100644 --- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/transport/http/apache/HttpClientConnectionTest.java +++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/transport/http/apache/HttpClientConnectionTest.java
@@ -80,58 +80,58 @@ private class HttpResponseMock extends AbstractHttpMessage implements HttpResponse { @Override public StatusLine getStatusLine() { - return null; + throw new UnsupportedOperationException(); } @Override public void setStatusLine(StatusLine statusLine) { - + throw new UnsupportedOperationException(); } @Override public void setStatusLine(ProtocolVersion protocolVersion, int i) { - + throw new UnsupportedOperationException(); } @Override public void setStatusLine(ProtocolVersion protocolVersion, int i, String s) { - + throw new UnsupportedOperationException(); } @Override public void setStatusCode(int i) throws IllegalStateException { - + throw new UnsupportedOperationException(); } @Override public void setReasonPhrase(String s) throws IllegalStateException { - + throw new UnsupportedOperationException(); } @Override public HttpEntity getEntity() { - return null; + throw new UnsupportedOperationException(); } @Override public void setEntity(HttpEntity httpEntity) { - + throw new UnsupportedOperationException(); } @Override public Locale getLocale() { - return null; + throw new UnsupportedOperationException(); } @Override public void setLocale(Locale locale) { - + throw new UnsupportedOperationException(); } @Override public ProtocolVersion getProtocolVersion() { - return null; + throw new UnsupportedOperationException(); } } }