commit 4f964552576afbcbaacb614471a20ed901430752
author Shawn O. Pearce <sop@google.com> Thu Dec 31 12:47:59 2009 -0800
committer Shawn O. Pearce <sop@google.com> Sat Jan 02 14:04:08 2010 -0800
tree b6ee3bf6a038ea0153bf07019a2583b494905834
parent 3264e18418e8cf31e3539dbcf4f19d07f17e1278

Gracefully ignore insert/update/delete with empty collections

If we were passed no items, don't create a statement.

Change-Id: I1e828057a30292a287e1b3c43c417d9588175970
Signed-off-by: Shawn O. Pearce <sop@google.com>

src/main/java/com/google/gwtorm/jdbc/JdbcAccess.java

diff --git a/src/main/java/com/google/gwtorm/jdbc/JdbcAccess.java b/src/main/java/com/google/gwtorm/jdbc/JdbcAccess.java
index 239d0ec..4b1c360 100644
--- a/src/main/java/com/google/gwtorm/jdbc/JdbcAccess.java
+++ b/src/main/java/com/google/gwtorm/jdbc/JdbcAccess.java
@@ -157,19 +157,22 @@
   protected void doInsert(final Iterable<T> instances, final JdbcTransaction txn)
       throws OrmException {
     try {
-      final PreparedStatement ps;
-
-      ps = schema.getConnection().prepareStatement(getInsertOneSql());
+      PreparedStatement ps = null;
       try {
         int cnt = 0;
         for (final T o : instances) {
+          if (ps == null) {
+            ps = schema.getConnection().prepareStatement(getInsertOneSql());
+          }
           bindOneInsert(ps, o);
           ps.addBatch();
           cnt++;
         }
         execute(ps, cnt);
       } finally {
-        ps.close();
+        if (ps != null) {
+          ps.close();
+        }
       }
     } catch (SQLException e) {
       throw convertError("insert", e);
@@ -180,19 +183,22 @@
   protected void doUpdate(final Iterable<T> instances, final JdbcTransaction txn)
       throws OrmException {
     try {
-      final PreparedStatement ps;
-
-      ps = schema.getConnection().prepareStatement(getUpdateOneSql());
+      PreparedStatement ps = null;
       try {
         int cnt = 0;
         for (final T o : instances) {
+          if (ps == null) {
+            ps = schema.getConnection().prepareStatement(getUpdateOneSql());
+          }
           bindOneUpdate(ps, o);
           ps.addBatch();
           cnt++;
         }
         execute(ps, cnt);
       } finally {
-        ps.close();
+        if (ps != null) {
+          ps.close();
+        }
       }
     } catch (SQLException e) {
       throw convertError("update", e);
@@ -206,38 +212,42 @@
     //
     Collection<T> inserts = null;
     try {
-      final PreparedStatement ps;
-
-      ps = schema.getConnection().prepareStatement(getUpdateOneSql());
+      PreparedStatement ps = null;
       try {
         int cnt = 0;
         for (final T o : instances) {
+          if (ps == null) {
+            ps = schema.getConnection().prepareStatement(getUpdateOneSql());
+          }
           bindOneUpdate(ps, o);
           ps.addBatch();
           cnt++;
         }
 
-        final int[] states = ps.executeBatch();
-        if (states == null) {
-          inserts = new ArrayList<T>(cnt);
-          for (T o : instances) {
-            inserts.add(o);
-          }
-        } else {
-          int i = 0;
-          for (T o : instances) {
-            if (states.length <= i || states[i] != 1) {
-              if (inserts == null) {
-                inserts = new ArrayList<T>(cnt - i);
-              }
+        if (0 < cnt) {
+          final int[] states = ps.executeBatch();
+          if (states == null) {
+            inserts = new ArrayList<T>(cnt);
+            for (T o : instances) {
               inserts.add(o);
             }
-            i++;
+          } else {
+            int i = 0;
+            for (T o : instances) {
+              if (states.length <= i || states[i] != 1) {
+                if (inserts == null) {
+                  inserts = new ArrayList<T>(cnt - i);
+                }
+                inserts.add(o);
+              }
+              i++;
+            }
           }
         }
-
       } finally {
-        ps.close();
+        if (ps != null) {
+          ps.close();
+        }
       }
     } catch (SQLException e) {
       throw convertError("update", e);
@@ -252,19 +262,22 @@
   protected void doDelete(final Iterable<T> instances, final JdbcTransaction txn)
       throws OrmException {
     try {
-      final PreparedStatement ps;
-
-      ps = schema.getConnection().prepareStatement(getDeleteOneSql());
+      PreparedStatement ps = null;
       try {
         int cnt = 0;
         for (final T o : instances) {
+          if (ps == null) {
+            ps = schema.getConnection().prepareStatement(getDeleteOneSql());
+          }
           bindOneDelete(ps, o);
           ps.addBatch();
           cnt++;
         }
         execute(ps, cnt);
       } finally {
-        ps.close();
+        if (ps != null) {
+          ps.close();
+        }
       }
     } catch (SQLException e) {
       throw convertError("delete", e);